summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRob Clark <robdclark@chromium.org>2023-01-20 02:17:34 +0300
committerHeiko Stuebner <heiko@sntech.de>2023-02-05 17:32:35 +0300
commit8ee3b0e85f6ccd9e6c527bc50eaba774c3bb18d0 (patch)
tree3da954cb3df8f11ac53b76cc2cb5fda76ea80e9a
parent0020d4cfa3eea0e5fad23af49411217da854fc83 (diff)
downloadlinux-8ee3b0e85f6ccd9e6c527bc50eaba774c3bb18d0.tar.xz
drm/rockchip: Drop unbalanced obj unref
In the error path, rockchip_drm_gem_object_mmap() is dropping an obj reference that it doesn't own. Fixes: 41315b793e13 ("drm/rockchip: use drm_gem_mmap helpers") Signed-off-by: Rob Clark <robdclark@chromium.org> Signed-off-by: Heiko Stuebner <heiko@sntech.de> Link: https://patchwork.freedesktop.org/patch/msgid/20230119231734.2884543-1-robdclark@gmail.com
-rw-r--r--drivers/gpu/drm/rockchip/rockchip_drm_gem.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index c9507d27f0ba..7f5698e3c554 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -262,9 +262,6 @@ static int rockchip_drm_gem_object_mmap(struct drm_gem_object *obj,
else
ret = rockchip_drm_gem_object_mmap_dma(obj, vma);
- if (ret)
- drm_gem_vm_close(vma);
-
return ret;
}