diff options
| author | Tejun Heo <tj@kernel.org> | 2019-06-14 01:30:37 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-07-26 10:13:07 +0300 |
| commit | bea58a0e6844f244d8d1789f08dab3678483f24c (patch) | |
| tree | 478c31640631ad2306237ece36a397b53374c32a | |
| parent | d9b2310494f7925905ee151bb6f6556559efefe6 (diff) | |
| download | linux-bea58a0e6844f244d8d1789f08dab3678483f24c.tar.xz | |
blk-iolatency: clear use_delay when io.latency is set to zero
commit 5de0073fcd50cc1f150895a7bb04d3cf8067b1d7 upstream.
If use_delay was non-zero when the latency target of a cgroup was set
to zero, it will stay stuck until io.latency is enabled on the cgroup
again. This keeps readahead disabled for the cgroup impacting
performance negatively.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Josef Bacik <jbacik@fb.com>
Fixes: d70675121546 ("block: introduce blk-iolatency io controller")
Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | block/blk-iolatency.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c index 072e1edcf83d..51070a730e3c 100644 --- a/block/blk-iolatency.c +++ b/block/blk-iolatency.c @@ -758,8 +758,10 @@ static int iolatency_set_min_lat_nsec(struct blkcg_gq *blkg, u64 val) if (!oldval && val) return 1; - if (oldval && !val) + if (oldval && !val) { + blkcg_clear_delay(blkg); return -1; + } return 0; } |