diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-03-02 17:47:05 +0300 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2023-03-07 14:19:26 +0300 |
| commit | db0664d1afe0600b07c1754fcc6bd300d8482071 (patch) | |
| tree | 386831307ab4d1933178e1f02d0cfe768de34d97 | |
| parent | 96c59f596ebe7d5f5a03f17a16a15e19f22cf666 (diff) | |
| download | linux-db0664d1afe0600b07c1754fcc6bd300d8482071.tar.xz | |
platform/x86: adv_swbutton: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230302144732.1903781-3-u.kleine-koenig@pengutronix.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
| -rw-r--r-- | drivers/platform/x86/adv_swbutton.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/platform/x86/adv_swbutton.c b/drivers/platform/x86/adv_swbutton.c index 38693b735c87..6b23ba78e028 100644 --- a/drivers/platform/x86/adv_swbutton.c +++ b/drivers/platform/x86/adv_swbutton.c @@ -90,14 +90,12 @@ static int adv_swbutton_probe(struct platform_device *device) return 0; } -static int adv_swbutton_remove(struct platform_device *device) +static void adv_swbutton_remove(struct platform_device *device) { acpi_handle handle = ACPI_HANDLE(&device->dev); acpi_remove_notify_handler(handle, ACPI_DEVICE_NOTIFY, adv_swbutton_notify); - - return 0; } static const struct acpi_device_id button_device_ids[] = { @@ -112,7 +110,7 @@ static struct platform_driver adv_swbutton_driver = { .acpi_match_table = button_device_ids, }, .probe = adv_swbutton_probe, - .remove = adv_swbutton_remove, + .remove_new = adv_swbutton_remove, }; module_platform_driver(adv_swbutton_driver); |