diff options
| author | Weichen Chen <weichen.chen@mediatek.com> | 2023-02-24 05:36:32 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-02-23 10:24:55 +0300 |
| commit | e9f6ac50890104fdf8194f2865680689239d30fb (patch) | |
| tree | 91ccb6a5ba88e657c76c34bdd0e7f4eacac8b402 | |
| parent | 93df0a2a0b3cde2d7ab3a52ed46ea1d6d4aaba5f (diff) | |
| download | linux-e9f6ac50890104fdf8194f2865680689239d30fb.tar.xz | |
pstore/ram: Fix crash when setting number of cpus to an odd number
[ Upstream commit d49270a04623ce3c0afddbf3e984cb245aa48e9c ]
When the number of cpu cores is adjusted to 7 or other odd numbers,
the zone size will become an odd number.
The address of the zone will become:
addr of zone0 = BASE
addr of zone1 = BASE + zone_size
addr of zone2 = BASE + zone_size*2
...
The address of zone1/3/5/7 will be mapped to non-alignment va.
Eventually crashes will occur when accessing these va.
So, use ALIGN_DOWN() to make sure the zone size is even
to avoid this bug.
Signed-off-by: Weichen Chen <weichen.chen@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Tested-by: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Link: https://lore.kernel.org/r/20230224023632.6840-1-weichen.chen@mediatek.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | fs/pstore/ram.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index 65cbc8a60ca3..9f83d8eba0e6 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -563,6 +563,7 @@ static int ramoops_init_przs(const char *name, } zone_sz = mem_sz / *cnt; + zone_sz = ALIGN_DOWN(zone_sz, 2); if (!zone_sz) { dev_err(dev, "%s zone size == 0\n", name); goto fail; |