diff options
| author | Zheng Yongjun <zhengyongjun3@huawei.com> | 2020-12-29 16:48:34 +0300 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2021-01-09 00:39:24 +0300 |
| commit | ec24e11e0817404ef9e04b50170e1a68793cd9f5 (patch) | |
| tree | 93eece960e473dc112aa44952fc783cb6363ef9e | |
| parent | 619775c3cfd2bc8559abc4395bf7d85b72bd723f (diff) | |
| download | linux-ec24e11e0817404ef9e04b50170e1a68793cd9f5.tar.xz | |
bpf: Replace fput with sockfd_put in sock map
The function sockfd_lookup uses fget on the value that is stored in
the file field of the returned structure, so fput should ultimately
be applied to this value. This can be done directly, but it seems
better to use the specific macro sockfd_put, which does the same
thing.
The cleanup was done using the following semantic patch:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression s;
@@
s = sockfd_lookup(...)
...
+ sockfd_put(s);
?- fput(s->file);
// </smpl>
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20201229134834.22962-1-zhengyongjun3@huawei.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
| -rw-r--r-- | net/core/sock_map.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/sock_map.c b/net/core/sock_map.c index 64b5ec14ff50..d758fb83c884 100644 --- a/net/core/sock_map.c +++ b/net/core/sock_map.c @@ -602,7 +602,7 @@ int sock_map_update_elem_sys(struct bpf_map *map, void *key, void *value, ret = sock_hash_update_common(map, key, sk, flags); sock_map_sk_release(sk); out: - fput(sock->file); + sockfd_put(sock); return ret; } |