summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKaixu Xia <kaixuxia@tencent.com>2022-09-13 12:11:25 +0300
committerAndrew Morton <akpm@linux-foundation.org>2022-10-04 00:03:14 +0300
commitf1c71c2825218dc8b35c04ab439fdf3d32778c7c (patch)
treecb30fe8884dff50e14bc0860ba0e12bd3efe034b
parent8ef4d5caa66d62b3b87a14d01562fb487651df2e (diff)
downloadlinux-f1c71c2825218dc8b35c04ab439fdf3d32778c7c.tar.xz
mm/damon/sysfs: simplify the variable 'pid' assignment operation
We can initialize the variable 'pid' with '-1' in pid_show() to simplify the variable assignment operation and make the code more readable. Link: https://lkml.kernel.org/r/1663060287-30201-3-git-send-email-kaixuxia@tencent.com Signed-off-by: Kaixu Xia <kaixuxia@tencent.com> Reviewed-by: SeongJae Park <sj@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-rw-r--r--mm/damon/sysfs.c11
1 files changed, 4 insertions, 7 deletions
diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index 3dbf3804ec88..1fa0023f136e 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -2592,19 +2592,16 @@ static ssize_t pid_show(struct kobject *kobj,
struct damon_sysfs_kdamond *kdamond = container_of(kobj,
struct damon_sysfs_kdamond, kobj);
struct damon_ctx *ctx;
- int pid;
+ int pid = -1;
if (!mutex_trylock(&damon_sysfs_lock))
return -EBUSY;
ctx = kdamond->damon_ctx;
- if (!ctx) {
- pid = -1;
+ if (!ctx)
goto out;
- }
+
mutex_lock(&ctx->kdamond_lock);
- if (!ctx->kdamond)
- pid = -1;
- else
+ if (ctx->kdamond)
pid = ctx->kdamond->pid;
mutex_unlock(&ctx->kdamond_lock);
out: