diff options
author | Mark Rutland <mark.rutland@arm.com> | 2020-04-21 15:10:14 +0300 |
---|---|---|
committer | Catalin Marinas <catalin.marinas@arm.com> | 2020-04-21 17:52:56 +0300 |
commit | 3fabb43818c9bfe7c4084badfa21d4e8187021a6 (patch) | |
tree | 6e72ca8a70648b08c5b03fb984374e406701ad37 /Documentation/arm64 | |
parent | ae83d0b416db002fe95601e7f97f64b59514d936 (diff) | |
download | linux-3fabb43818c9bfe7c4084badfa21d4e8187021a6.tar.xz |
arm64: sync kernel APIAKey when installing
A direct write to a APxxKey_EL1 register requires a context
synchronization event to ensure that indirect reads made by subsequent
instructions (e.g. AUTIASP, PACIASP) observe the new value.
When we initialize the boot task's APIAKey in boot_init_stack_canary()
via ptrauth_keys_switch_kernel() we miss the necessary ISB, and so there
is a window where instructions are not guaranteed to use the new APIAKey
value. This has been observed to result in boot-time crashes where
PACIASP and AUTIASP within a function used a mixture of the old and new
key values.
Fix this by having ptrauth_keys_switch_kernel() synchronize the new key
value with an ISB. At the same time, __ptrauth_key_install() is renamed
to __ptrauth_key_install_nosync() so that it is obvious that this
performs no synchronization itself.
Fixes: 28321582334c261c ("arm64: initialize ptrauth keys for kernel booting task")
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Reported-by: Will Deacon <will@kernel.org>
Cc: Amit Daniel Kachhap <amit.kachhap@arm.com>
Cc: Marc Zyngier <maz@kernel.org>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Tested-by: Will Deacon <will@kernel.org>
Diffstat (limited to 'Documentation/arm64')
0 files changed, 0 insertions, 0 deletions