diff options
| author | Jarkko Sakkinen <jarkko@kernel.org> | 2024-05-13 21:19:04 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-05-25 17:28:40 +0300 |
| commit | d32c6e09f7c4bec3ebc4941323f0aa6366bc1487 (patch) | |
| tree | 3c543b1a90500e17d8c588b8a7aeefa5e15230d7 /Documentation/bpf | |
| parent | 838b49e211d59fa827ff9df062d4020917cffbdf (diff) | |
| download | linux-d32c6e09f7c4bec3ebc4941323f0aa6366bc1487.tar.xz | |
KEYS: trusted: Do not use WARN when encode fails
commit 050bf3c793a07f96bd1e2fd62e1447f731ed733b upstream.
When asn1_encode_sequence() fails, WARN is not the correct solution.
1. asn1_encode_sequence() is not an internal function (located
in lib/asn1_encode.c).
2. Location is known, which makes the stack trace useless.
3. Results a crash if panic_on_warn is set.
It is also noteworthy that the use of WARN is undocumented, and it
should be avoided unless there is a carefully considered rationale to
use it.
Replace WARN with pr_err, and print the return value instead, which is
only useful piece of information.
Cc: stable@vger.kernel.org # v5.13+
Fixes: f2219745250f ("security: keys: trusted: use ASN.1 TPM2 key format for the blobs")
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'Documentation/bpf')
0 files changed, 0 insertions, 0 deletions