diff options
author | Demi Marie Obenour <demi@invisiblethingslab.com> | 2022-07-11 02:05:22 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-07-29 18:19:07 +0300 |
commit | 7a99c7c32c85cd5239600533b77a34f884741fcc (patch) | |
tree | 4775e5344a1ebea2d1445eeb5b6a2dfc232bcc9c /Documentation/hid | |
parent | 2ee0cab11f6626071f8a64c7792406dabdd94c8d (diff) | |
download | linux-7a99c7c32c85cd5239600533b77a34f884741fcc.tar.xz |
xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE
commit 166d3863231667c4f64dee72b77d1102cdfad11f upstream.
The error paths of gntdev_mmap() can call unmap_grant_pages() even
though not all of the pages have been successfully mapped. This will
trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of
warnings can be very large; I have observed thousands of lines of
warnings in the systemd journal.
Avoid this problem by only warning on unmapping failure if the handle
being unmapped is not INVALID_GRANT_HANDLE. The handle field of any
page that was not successfully mapped will be INVALID_GRANT_HANDLE, so
this catches all cases where unmapping can legitimately fail.
Fixes: dbe97cff7dd9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()")
Cc: stable@vger.kernel.org
Suggested-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com>
Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20220710230522.1563-1-demi@invisiblethingslab.com
Signed-off-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'Documentation/hid')
0 files changed, 0 insertions, 0 deletions