diff options
| author | Josh Poimboeuf <jpoimboe@redhat.com> | 2020-04-01 21:23:28 +0300 |
|---|---|---|
| committer | Borislav Petkov <bp@suse.de> | 2020-04-14 13:06:21 +0300 |
| commit | b401efc120a399dfda1f4d2858a4de365c9b08ef (patch) | |
| tree | 37d61c763f9ead3e330547531b559f821195e264 /Documentation | |
| parent | e81e0724432542af8d8c702c31e9d82f57b1ff31 (diff) | |
| download | linux-b401efc120a399dfda1f4d2858a4de365c9b08ef.tar.xz | |
objtool: Fix switch table detection in .text.unlikely
If a switch jump table's indirect branch is in a ".cold" subfunction in
.text.unlikely, objtool doesn't detect it, and instead prints a false
warning:
drivers/media/v4l2-core/v4l2-ioctl.o: warning: objtool: v4l_print_format.cold()+0xd6: sibling call from callable instruction with modified stack frame
drivers/hwmon/max6650.o: warning: objtool: max6650_probe.cold()+0xa5: sibling call from callable instruction with modified stack frame
drivers/media/dvb-frontends/drxk_hard.o: warning: objtool: init_drxk.cold()+0x16f: sibling call from callable instruction with modified stack frame
Fix it by comparing the function, instead of the section and offset.
Fixes: 13810435b9a7 ("objtool: Support GCC 8's cold subfunctions")
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/157c35d42ca9b6354bbb1604fe9ad7d1153ccb21.1585761021.git.jpoimboe@redhat.com
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions