diff options
| author | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2022-09-29 04:15:56 +0300 |
|---|---|---|
| committer | Bjorn Andersson <andersson@kernel.org> | 2022-10-18 06:01:46 +0300 |
| commit | 978bc4c578a6d7baffc5646b0f327da036b3051b (patch) | |
| tree | bd7aa3cb53362d9cc0f67fda3cad92bd29139270 /arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | |
| parent | 5aa332c5e7ca2469c9ff55cf294eddb33a2c8e4b (diff) | |
| download | linux-978bc4c578a6d7baffc5646b0f327da036b3051b.tar.xz | |
arm64: dts: qcom: msm8916-samsung-a2015: fix polarity of "enable" line of NFC chip
According to s3fwrn5 driver code the "enable" GPIO line is driven "high"
when chip is not in use (mode is S3FWRN5_MODE_COLD), and is driven "low"
when chip is in use.
s3fwrn5_phy_power_ctrl():
...
gpio_set_value(phy->gpio_en, 1);
...
if (mode != S3FWRN5_MODE_COLD) {
msleep(S3FWRN5_EN_WAIT_TIME);
gpio_set_value(phy->gpio_en, 0);
msleep(S3FWRN5_EN_WAIT_TIME);
}
Therefore the line described by "en-gpios" property should be annotated
as "active low".
The wakeup gpio appears to have correct polarity (active high).
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20220929011557.4165216-2-dmitry.torokhov@gmail.com
Diffstat (limited to 'arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi')
| -rw-r--r-- | arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi index 3255bd3fcb55..5f7cec347a4f 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi @@ -144,7 +144,7 @@ interrupt-parent = <&msmgpio>; interrupts = <21 IRQ_TYPE_EDGE_RISING>; - en-gpios = <&msmgpio 20 GPIO_ACTIVE_HIGH>; + en-gpios = <&msmgpio 20 GPIO_ACTIVE_LOW>; wake-gpios = <&msmgpio 49 GPIO_ACTIVE_HIGH>; clocks = <&rpmcc RPM_SMD_BB_CLK2_PIN>; |