diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2022-11-22 16:44:11 +0300 |
|---|---|---|
| committer | Arnd Bergmann <arnd@arndb.de> | 2022-11-23 01:12:18 +0300 |
| commit | ff5a19909b49fe5c0b01ae197f84b741e0f698dc (patch) | |
| tree | d6879de1c38f5e905e0453bf5ccac44edda8d1a4 /arch/arm64 | |
| parent | abd6e3d6d897df4e2d18effa948ef5e8b5aa8282 (diff) | |
| download | linux-ff5a19909b49fe5c0b01ae197f84b741e0f698dc.tar.xz | |
bus: ixp4xx: Don't touch bit 7 on IXP42x
We face some regressions on a few IXP42x systems when
accessing flash, the following unrelated error prints
appear from the PCI driver:
ixp4xx-pci c0000000.pci: PCI: abort_handler addr = 0xff9ffb5f,
isr = 0x0, status = 0x22a0
ixp4xx-pci c0000000.pci: imprecise abort
(...)
It turns out that while bit 7 is masked "reserved" it is
not unused, so masking it off as zero is dangerous, and
breaks flash access on some systems such as the NSLU2.
Be more careful and avoid masking off any of the reserved
bits 7, 8, 9 or 30. Only keep masking EXP_WORD (bit 2)
on IXP43x which is necessary in some setups.
Fixes: 1c953bda90ca ("bus: ixp4xx: Add a driver for IXP4xx expansion bus")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20221122134411.2030372-1-linus.walleij@linaro.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Diffstat (limited to 'arch/arm64')
0 files changed, 0 insertions, 0 deletions