summaryrefslogtreecommitdiff
path: root/arch/m68k/fpsp040
diff options
context:
space:
mode:
authorEric W. Biederman <ebiederm@xmission.com>2021-07-26 22:23:11 +0300
committerEric W. Biederman <ebiederm@xmission.com>2021-08-26 17:59:15 +0300
commita3616a3c02722d1edb95acc7fceade242f6553ba (patch)
tree50f31503491dafdc92a75b6946970ebfdb4ea93e /arch/m68k/fpsp040
parentb48c7236b13cb5ef1b5fdf744aa8841df0f7b43a (diff)
downloadlinux-a3616a3c02722d1edb95acc7fceade242f6553ba.tar.xz
signal/m68k: Use force_sigsegv(SIGSEGV) in fpsp040_die
In the fpsp040 code when copyin or copyout fails call force_sigsegv(SIGSEGV) instead of do_exit(SIGSEGV). This solves a couple of problems. Because do_exit embeds the ptrace stop PTRACE_EVENT_EXIT a complete stack frame needs to be present for that to work correctly. There is always the information needed for a ptrace stop where get_signal is called. So exiting with a signal solves the ptrace issue. Further exiting with a signal ensures that all of the threads in a process are killed not just the thread that malfunctioned. Which avoids confusing userspace. To make force_sigsegv(SIGSEGV) work in fpsp040_die modify the code to save all of the registers and jump to ret_from_exception (which ultimately calls get_signal) after fpsp040_die returns. v2: Updated the branches to use gas's pseudo ops that automatically calculate the best branch instruction to use for the purpose. v1: https://lkml.kernel.org/r/87a6m8kgtx.fsf_-_@disp2133 Link: https://lkml.kernel.org/r/87tukghjfs.fsf_-_@disp2133 Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'arch/m68k/fpsp040')
-rw-r--r--arch/m68k/fpsp040/skeleton.S3
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/m68k/fpsp040/skeleton.S b/arch/m68k/fpsp040/skeleton.S
index a8f41615d94a..439395aa6fb4 100644
--- a/arch/m68k/fpsp040/skeleton.S
+++ b/arch/m68k/fpsp040/skeleton.S
@@ -502,7 +502,8 @@ in_ea:
.section .fixup,#alloc,#execinstr
.even
1:
- jbra fpsp040_die
+ jbsr fpsp040_die
+ jbra .Lnotkern
.section __ex_table,#alloc
.align 4