diff options
| author | Geert Uytterhoeven <geert@linux-m68k.org> | 2023-09-13 17:08:15 +0300 |
|---|---|---|
| committer | Geert Uytterhoeven <geert@linux-m68k.org> | 2023-10-06 11:03:02 +0300 |
| commit | 7509c04afe930573c8f4ab6abda3743c2c184d66 (patch) | |
| tree | 00c0a0c3ab452f55a107f7db9344583157db1147 /arch/m68k | |
| parent | 55775fe94d7ff260a9f63b2e376bab71afebf6ec (diff) | |
| download | linux-7509c04afe930573c8f4ab6abda3743c2c184d66.tar.xz | |
m68k: apollo: Replace set but not used variable by READ_ONCE()
When building with W=1:
arch/m68k/apollo/config.c: In function ‘dn_timer_int’:
arch/m68k/apollo/config.c:171:32: warning: variable ‘x’ set but not used [-Wunused-but-set-variable]
149 | volatile unsigned char x;
| ^
Fix this by using READ_ONCE(), and removing the variable.
As READ_ONCE() casts to volatile internally, remove the existing cast.
Deduplicate the remaining casts by introducing an intermediary.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/d0299797d6bf747eca2da998c6c6256485a9f52e.1694613528.git.geert@linux-m68k.org
Diffstat (limited to 'arch/m68k')
| -rw-r--r-- | arch/m68k/apollo/config.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/m68k/apollo/config.c b/arch/m68k/apollo/config.c index 0e6801eecbaf..7afefb019150 100644 --- a/arch/m68k/apollo/config.c +++ b/arch/m68k/apollo/config.c @@ -146,13 +146,13 @@ void __init config_apollo(void) irqreturn_t dn_timer_int(int irq, void *dev_id) { - volatile unsigned char x; + unsigned char *at = (unsigned char *)apollo_timer; legacy_timer_tick(1); timer_heartbeat(); - x = *(volatile unsigned char *)(apollo_timer + 3); - x = *(volatile unsigned char *)(apollo_timer + 5); + READ_ONCE(*(at + 3)); + READ_ONCE(*(at + 5)); return IRQ_HANDLED; } |