diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2022-10-28 16:23:44 +0300 |
|---|---|---|
| committer | Thomas Bogendoerfer <tsbogend@alpha.franken.de> | 2022-11-11 17:53:58 +0300 |
| commit | 648060902aa302331b5d6e4f26d8ee0761d239ab (patch) | |
| tree | d575c80faf22cc8d50f6af9bca28e41b69b3af4e /arch/mips/pic32/pic32mzda/init.c | |
| parent | 64ac0befe75bdfaffc396c2b4a0ed5ae6920eeee (diff) | |
| download | linux-648060902aa302331b5d6e4f26d8ee0761d239ab.tar.xz | |
MIPS: pic32: treat port as signed integer
get_port_from_cmdline() returns an int, yet is assigned to a char, which
is wrong in its own right, but also, with char becoming unsigned, this
poses problems, because -1 is used as an error value. Further
complicating things, fw_init_early_console() is only ever called with a
-1 argument. Fix this up by removing the unused argument from
fw_init_early_console() and treating port as a proper signed integer.
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Diffstat (limited to 'arch/mips/pic32/pic32mzda/init.c')
| -rw-r--r-- | arch/mips/pic32/pic32mzda/init.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/mips/pic32/pic32mzda/init.c b/arch/mips/pic32/pic32mzda/init.c index 08c46cf122d7..53b227a9074c 100644 --- a/arch/mips/pic32/pic32mzda/init.c +++ b/arch/mips/pic32/pic32mzda/init.c @@ -47,7 +47,7 @@ void __init plat_mem_setup(void) strscpy(arcs_cmdline, boot_command_line, COMMAND_LINE_SIZE); #ifdef CONFIG_EARLY_PRINTK - fw_init_early_console(-1); + fw_init_early_console(); #endif pic32_config_init(); } |