diff options
author | Zekun Shen <bruceshenzk@gmail.com> | 2020-06-15 18:50:29 +0300 |
---|---|---|
committer | Sasha Levin <sashal@kernel.org> | 2020-06-30 22:38:06 +0300 |
commit | 9cef5a5722202e49bac8a07f93d0e74b5501ce86 (patch) | |
tree | 52c4ea1ddad22441af767edfc968ef593eb7f531 /arch/s390 | |
parent | a5eda762c897730f2ce7d170846a142b529bde57 (diff) | |
download | linux-9cef5a5722202e49bac8a07f93d0e74b5501ce86.tar.xz |
net: alx: fix race condition in alx_remove
[ Upstream commit e89df5c4322c1bf495f62d74745895b5fd2a4393 ]
There is a race condition exist during termination. The path is
alx_stop and then alx_remove. An alx_schedule_link_check could be called
before alx_stop by interrupt handler and invoke alx_link_check later.
Alx_stop frees the napis, and alx_remove cancels any pending works.
If any of the work is scheduled before termination and invoked before
alx_remove, a null-ptr-deref occurs because both expect alx->napis[i].
This patch fix the race condition by moving cancel_work_sync functions
before alx_free_napis inside alx_stop. Because interrupt handler can call
alx_schedule_link_check again, alx_free_irq is moved before
cancel_work_sync calls too.
Signed-off-by: Zekun Shen <bruceshenzk@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'arch/s390')
0 files changed, 0 insertions, 0 deletions