summaryrefslogtreecommitdiff
path: root/arch/um
diff options
context:
space:
mode:
authorZhen Lei <thunder.leizhen@huawei.com>2021-05-08 06:13:54 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-07-20 17:16:12 +0300
commit33a260142e15159b7cb4591000abe5e7d667a8c1 (patch)
tree171a8c6cd46ca084d4ad690116706f88c5c9cf17 /arch/um
parent743f6b973c8ba8a0a5ed15ab11e1d07fa00d5368 (diff)
downloadlinux-33a260142e15159b7cb4591000abe5e7d667a8c1.tar.xz
um: fix error return code in slip_open()
[ Upstream commit b77e81fbe5f5fb4ad9a61ec80f6d1e30b6da093a ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: a3c77c67a443 ("[PATCH] uml: slirp and slip driver cleanups and fixes") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Acked-By: anton.ivanov@cambridgegreys.com Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'arch/um')
-rw-r--r--arch/um/drivers/slip_user.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/um/drivers/slip_user.c b/arch/um/drivers/slip_user.c
index 0d6b66c64a81..76d155631c5d 100644
--- a/arch/um/drivers/slip_user.c
+++ b/arch/um/drivers/slip_user.c
@@ -145,7 +145,8 @@ static int slip_open(void *data)
}
sfd = err;
- if (set_up_tty(sfd))
+ err = set_up_tty(sfd);
+ if (err)
goto out_close2;
pri->slave = sfd;