summaryrefslogtreecommitdiff
path: root/arch/x86
diff options
context:
space:
mode:
authorDavidlohr Bueso <dave@stgolabs.net>2017-09-13 23:08:20 +0300
committerPaolo Bonzini <pbonzini@redhat.com>2017-09-15 17:57:11 +0300
commitcc1b46803a671047be22f7832ef4a2bb3f63dd94 (patch)
treec15a9fa0ebce815977ca81aa74f13024523b95d6 /arch/x86
parentb9f67a420b3d76991592558af06e9cf1b8953b3d (diff)
downloadlinux-cc1b46803a671047be22f7832ef4a2bb3f63dd94.tar.xz
kvm,lapic: Justify use of swait_active()
A comment might serve future readers. Signed-off-by: Davidlohr Bueso <dbueso@suse.de> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'arch/x86')
-rw-r--r--arch/x86/kvm/lapic.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index aaf10b6f5380..69c5612be786 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -1324,6 +1324,10 @@ static void apic_timer_expired(struct kvm_lapic *apic)
atomic_inc(&apic->lapic_timer.pending);
kvm_set_pending_timer(vcpu);
+ /*
+ * For x86, the atomic_inc() is serialized, thus
+ * using swait_active() is safe.
+ */
if (swait_active(q))
swake_up(q);