diff options
author | John Soni Jose <sony.john@avagotech.com> | 2015-06-24 04:11:58 +0300 |
---|---|---|
committer | Sasha Levin <sasha.levin@oracle.com> | 2015-09-17 08:30:30 +0300 |
commit | 20b38ab5b687df3dbb873cfb0efa946a021f890a (patch) | |
tree | ce2ad87f2a9f6e2d8460fcdb69cefc578559ff1a /block | |
parent | 38da5ebc9d7b7ba9482f65cd4cf1c55bd6c28c72 (diff) | |
download | linux-20b38ab5b687df3dbb873cfb0efa946a021f890a.tar.xz |
libiscsi: Fix host busy blocking during connection teardown
[ Upstream commit 660d0831d1494a6837b2f810d08b5be092c1f31d ]
In case of hw iscsi offload, an host can have N-number of active
connections. There can be IO's running on some connections which
make host->host_busy always TRUE. Now if logout from a connection
is tried then the code gets into an infinite loop as host->host_busy
is always TRUE.
iscsi_conn_teardown(....)
{
.........
/*
* Block until all in-progress commands for this connection
* time out or fail.
*/
for (;;) {
spin_lock_irqsave(session->host->host_lock, flags);
if (!atomic_read(&session->host->host_busy)) { /* OK for ERL == 0 */
spin_unlock_irqrestore(session->host->host_lock, flags);
break;
}
spin_unlock_irqrestore(session->host->host_lock, flags);
msleep_interruptible(500);
iscsi_conn_printk(KERN_INFO, conn, "iscsi conn_destroy(): "
"host_busy %d host_failed %d\n",
atomic_read(&session->host->host_busy),
session->host->host_failed);
................
...............
}
}
This is not an issue with software-iscsi/iser as each cxn is a separate
host.
Fix:
Acquiring eh_mutex in iscsi_conn_teardown() before setting
session->state = ISCSI_STATE_TERMINATE.
Signed-off-by: John Soni Jose <sony.john@avagotech.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Reviewed-by: Chris Leech <cleech@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: James Bottomley <JBottomley@Odin.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions