diff options
author | Russell King (Oracle) <rmk+kernel@armlinux.org.uk> | 2021-10-28 17:55:34 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-11-18 16:04:12 +0300 |
commit | fb41b8f5e855794f180f0f8a118abeb662436a07 (patch) | |
tree | ff4c7e74dc5c3f3fee68774422cd43778c333303 /crypto | |
parent | 08449a5c0e56373847857cc20e2ea22a61bd6600 (diff) | |
download | linux-fb41b8f5e855794f180f0f8a118abeb662436a07.tar.xz |
net: phylink: avoid mvneta warning when setting pause parameters
[ Upstream commit fd8d9731bcdfb22d28e45bce789bcb211c868c78 ]
mvneta does not support asymetric pause modes, and it flags this by the
lack of AsymPause in the supported field. When setting pause modes, we
check that pause->rx_pause == pause->tx_pause, but only when pause
autoneg is enabled. When pause autoneg is disabled, we still allow
pause->rx_pause != pause->tx_pause, which is incorrect when the MAC
does not support asymetric pause, and causes mvneta to issue a warning.
Fix this by removing the test for pause->autoneg, so we always check
that pause->rx_pause == pause->tx_pause for network devices that do not
support AsymPause.
Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'crypto')
0 files changed, 0 insertions, 0 deletions