summaryrefslogtreecommitdiff
path: root/crypto
diff options
context:
space:
mode:
authorTim Gardner <tim.gardner@canonical.com>2021-09-10 22:01:17 +0300
committerHerbert Xu <herbert@gondor.apana.org.au>2021-09-17 06:06:15 +0300
commit81f53028dfbc79844f727a7c13d337ba827a471c (patch)
tree3d1a40f0ad19bf24b7071037ee8401e0d0f1240f /crypto
parent5e91f56a0bb32fd14096e20224bf4f93f1b174b1 (diff)
downloadlinux-81f53028dfbc79844f727a7c13d337ba827a471c.tar.xz
crypto: drbg - Fix unused value warning in drbg_healthcheck_sanity()
Coverity warns uf an unused value: CID 44865 (#2 of 2): Unused value (UNUSED_VALUE) assigned_value: Assigning value -14 to ret here, but that stored value is overwritten before it can be used. 2006 int ret = -EFAULT; ... value_overwrite: Overwriting previous write to ret with value from drbg_seed(drbg, &addtl, false). 2052 ret = drbg_seed(drbg, &addtl, false); Fix this by removing the variable initializer. Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: linux-crypto@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Tim Gardner <tim.gardner@canonical.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'crypto')
-rw-r--r--crypto/drbg.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/drbg.c b/crypto/drbg.c
index ea85d4a0fe9e..f72f340a1321 100644
--- a/crypto/drbg.c
+++ b/crypto/drbg.c
@@ -2003,7 +2003,7 @@ static inline int __init drbg_healthcheck_sanity(void)
#define OUTBUFLEN 16
unsigned char buf[OUTBUFLEN];
struct drbg_state *drbg = NULL;
- int ret = -EFAULT;
+ int ret;
int rc = -EFAULT;
bool pr = false;
int coreref = 0;