summaryrefslogtreecommitdiff
path: root/drivers/acpi
diff options
context:
space:
mode:
authorQiushi Wu <wu000273@umn.edu>2020-05-28 00:17:17 +0300
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2020-05-28 14:45:34 +0300
commit6e6c25283dff866308c87b49434c7dbad4774cc0 (patch)
tree034da068ffc3d5ef77aac53e41fe7ee165ed390b /drivers/acpi
parent9cb1fd0efd195590b828b9b865421ad345a4a145 (diff)
downloadlinux-6e6c25283dff866308c87b49434c7dbad4774cc0.tar.xz
ACPI: sysfs: Fix reference count leak in acpi_sysfs_add_hotplug_profile()
kobject_init_and_add() takes reference even when it fails. Thus, when kobject_init_and_add() returns an error, kobject_put() must be called to properly clean up the kobject. Fixes: 3f8055c35836 ("ACPI / hotplug: Introduce user space interface for hotplug profiles") Signed-off-by: Qiushi Wu <wu000273@umn.edu> Cc: 3.10+ <stable@vger.kernel.org> # 3.10+ Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/acpi')
-rw-r--r--drivers/acpi/sysfs.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
index c60d2c6d31d6..3a89909b50a6 100644
--- a/drivers/acpi/sysfs.c
+++ b/drivers/acpi/sysfs.c
@@ -993,8 +993,10 @@ void acpi_sysfs_add_hotplug_profile(struct acpi_hotplug_profile *hotplug,
error = kobject_init_and_add(&hotplug->kobj,
&acpi_hotplug_profile_ktype, hotplug_kobj, "%s", name);
- if (error)
+ if (error) {
+ kobject_put(&hotplug->kobj);
goto err_out;
+ }
kobject_uevent(&hotplug->kobj, KOBJ_ADD);
return;