summaryrefslogtreecommitdiff
path: root/drivers/android
diff options
context:
space:
mode:
authorCarlos Llamas <cmllamas@google.com>2022-04-30 02:56:40 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-05-09 16:43:24 +0300
commit9474be34a72726c5a20467e36d9b08102ff9d304 (patch)
tree3a77620b98e1a1f22c6ab133719c343db1498aac /drivers/android
parent83b716d1fe9e0e5b0ba6ad08519e832b881e8e5c (diff)
downloadlinux-9474be34a72726c5a20467e36d9b08102ff9d304.tar.xz
binder: add failed transaction logging info
Make sure we log relevant information about failed transactions such as the target proc/thread, call type and transaction id. These details are particularly important when debugging userspace issues. Acked-by: Christian Brauner (Microsoft) <brauner@kernel.org> Acked-by: Todd Kjos <tkjos@google.com> Signed-off-by: Carlos Llamas <cmllamas@google.com> Link: https://lore.kernel.org/r/20220429235644.697372-2-cmllamas@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/android')
-rw-r--r--drivers/android/binder.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 5ffdad274301..f0690d46caa1 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -3470,8 +3470,12 @@ err_invalid_target_handle:
}
binder_debug(BINDER_DEBUG_FAILED_TRANSACTION,
- "%d:%d transaction failed %d/%d, size %lld-%lld line %d\n",
- proc->pid, thread->pid, return_error, return_error_param,
+ "%d:%d transaction %s to %d:%d failed %d/%d/%d, size %lld-%lld line %d\n",
+ proc->pid, thread->pid, reply ? "reply" :
+ (tr->flags & TF_ONE_WAY ? "async" : "call"),
+ target_proc ? target_proc->pid : 0,
+ target_thread ? target_thread->pid : 0,
+ t_debug_id, return_error, return_error_param,
(u64)tr->data_size, (u64)tr->offsets_size,
return_error_line);