diff options
author | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> | 2023-05-23 18:47:47 +0300 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2023-05-24 13:21:51 +0300 |
commit | 95856d1f3c223c015780fffb8373a827fc4efd2e (patch) | |
tree | 6b564025daf872332334f7c47d71de5eb0a9b61b /drivers/base/regmap | |
parent | 3981514180c987a79ea98f0ae06a7cbf58a9ac0f (diff) | |
download | linux-95856d1f3c223c015780fffb8373a827fc4efd2e.tar.xz |
regmap: sdw: check for invalid multi-register writes config
SoundWire code as it is only supports Bulk register writes and
it does not support multi-register writes.
Any drivers that set can_multi_write and use regmap_multi_reg_write() will
easily endup with programming the hardware incorrectly without any errors.
So, add this check in bus code to be able to validate the drivers config.
Fixes: 522272047dc6 ("regmap: sdw: Remove 8-bit value size restriction")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20230523154747.5429-1-srinivas.kandagatla@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/base/regmap')
-rw-r--r-- | drivers/base/regmap/regmap-sdw.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/base/regmap/regmap-sdw.c b/drivers/base/regmap/regmap-sdw.c index 09899ae99fc1..159c0b740b00 100644 --- a/drivers/base/regmap/regmap-sdw.c +++ b/drivers/base/regmap/regmap-sdw.c @@ -59,6 +59,10 @@ static int regmap_sdw_config_check(const struct regmap_config *config) if (config->pad_bits != 0) return -ENOTSUPP; + /* Only bulk writes are supported not multi-register writes */ + if (config->can_multi_write) + return -ENOTSUPP; + return 0; } |