summaryrefslogtreecommitdiff
path: root/drivers/block/n64cart.c
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2021-09-09 12:06:08 +0300
committerJens Axboe <axboe@kernel.dk>2021-09-09 23:24:02 +0300
commit221e8360834c59f0c9952630fa5904a94ebd2bb8 (patch)
tree87eba00454997fe9e21557a1b89857c94c9dd51c /drivers/block/n64cart.c
parent7f2a6a69f7ced6db8220298e0497cf60482a9d4b (diff)
downloadlinux-221e8360834c59f0c9952630fa5904a94ebd2bb8.tar.xz
n64cart: fix return value check in n64cart_probe()
In case of error, the function devm_platform_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: d9b2a2bbbb4d ("block: Add n64 cart driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> Link: https://lore.kernel.org/r/20210909090608.2989716-1-yangyingliang@huawei.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/block/n64cart.c')
-rw-r--r--drivers/block/n64cart.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/block/n64cart.c b/drivers/block/n64cart.c
index c84be0028f63..26798da661bd 100644
--- a/drivers/block/n64cart.c
+++ b/drivers/block/n64cart.c
@@ -129,8 +129,8 @@ static int __init n64cart_probe(struct platform_device *pdev)
}
reg_base = devm_platform_ioremap_resource(pdev, 0);
- if (!reg_base)
- return -EINVAL;
+ if (IS_ERR(reg_base))
+ return PTR_ERR(reg_base);
disk = blk_alloc_disk(NUMA_NO_NODE);
if (!disk)