diff options
| author | Dinghao Liu <dinghao.liu@zju.edu.cn> | 2020-05-28 10:21:04 +0300 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2020-07-01 06:17:14 +0300 |
| commit | 1f63c02277c76cc24d6acecdc3fb7b1575cbfbf7 (patch) | |
| tree | 0cef941b6e0ac75a2e8ed73058db381b4b62171a /drivers/char/hw_random | |
| parent | a24f9d6cf9bd65c1305344134e0182ed7bef76c8 (diff) | |
| download | linux-1f63c02277c76cc24d6acecdc3fb7b1575cbfbf7.tar.xz | |
hwrng: ks-sa - Fix runtime PM imbalance on error
[ Upstream commit 95459261c99f1621d90bc628c2a48e60b7cf9a88 ]
pm_runtime_get_sync() increments the runtime PM usage counter even
the call returns an error code. Thus a pairing decrement is needed
on the error handling path to keep the counter balanced.
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/char/hw_random')
| -rw-r--r-- | drivers/char/hw_random/ks-sa-rng.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/char/hw_random/ks-sa-rng.c b/drivers/char/hw_random/ks-sa-rng.c index 62c6696c1dbd..b6d7db362b21 100644 --- a/drivers/char/hw_random/ks-sa-rng.c +++ b/drivers/char/hw_random/ks-sa-rng.c @@ -216,6 +216,7 @@ static int ks_sa_rng_probe(struct platform_device *pdev) ret = pm_runtime_get_sync(dev); if (ret < 0) { dev_err(dev, "Failed to enable SA power-domain\n"); + pm_runtime_put_noidle(dev); pm_runtime_disable(dev); return ret; } |