summaryrefslogtreecommitdiff
path: root/drivers/comedi
diff options
context:
space:
mode:
authorGuo Zhengkui <guozhengkui@vivo.com>2022-05-13 10:16:06 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-05-19 19:54:45 +0300
commit80ad54a63af3a3e2eb701fbf30242a922c4fac47 (patch)
tree445d5cc17fb11ed1daef3909681f6f5022128420 /drivers/comedi
parent7394d2ebb651a9f62e08c6ab864aac015d27c64d (diff)
downloadlinux-80ad54a63af3a3e2eb701fbf30242a922c4fac47.tar.xz
drivers: comedi: replace ternary operator with min()
Fix the following coccicheck warning: drivers/comedi/drivers.c:857:12-13: WARNING opportunity for min(). min() macro is defined in include/linux/minmax.h. It avoids multiple evaluations of the arguments when non-constant and performs strict type-checking. Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com> Link: https://lore.kernel.org/r/20220513071608.49047-1-guozhengkui@vivo.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/comedi')
-rw-r--r--drivers/comedi/drivers.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/comedi/drivers.c b/drivers/comedi/drivers.c
index 8eb1f699a857..d4e2ed709bfc 100644
--- a/drivers/comedi/drivers.c
+++ b/drivers/comedi/drivers.c
@@ -854,7 +854,7 @@ int comedi_load_firmware(struct comedi_device *dev,
release_firmware(fw);
}
- return ret < 0 ? ret : 0;
+ return min(ret, 0);
}
EXPORT_SYMBOL_GPL(comedi_load_firmware);