summaryrefslogtreecommitdiff
path: root/drivers/cpufreq/ti-cpufreq.c
diff options
context:
space:
mode:
authorSuman Anna <s-anna@ti.com>2018-06-01 01:21:43 +0300
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2018-06-06 09:34:31 +0300
commite5d295b06d69a1924665a16a4987be475addd00f (patch)
tree1879ceaf9143c0ce44a545609dc183fccc981df9 /drivers/cpufreq/ti-cpufreq.c
parent08e9cc4032626792b49009547454bcef44c2e12b (diff)
downloadlinux-e5d295b06d69a1924665a16a4987be475addd00f.tar.xz
cpufreq: ti-cpufreq: Fix an incorrect error return value
Commit 05829d9431df (cpufreq: ti-cpufreq: kfree opp_data when failure) has fixed a memory leak in the failure path, however the patch returned a positive value on get_cpu_device() failure instead of the previous negative value. Fix this incorrect error return value properly. Fixes: 05829d9431df (cpufreq: ti-cpufreq: kfree opp_data when failure) Cc: 4.14+ <stable@vger.kernel.org> # v4.14+ Signed-off-by: Suman Anna <s-anna@ti.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpufreq/ti-cpufreq.c')
-rw-r--r--drivers/cpufreq/ti-cpufreq.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
index 6ba709b6f095..896caba5dfe5 100644
--- a/drivers/cpufreq/ti-cpufreq.c
+++ b/drivers/cpufreq/ti-cpufreq.c
@@ -226,7 +226,7 @@ static int ti_cpufreq_probe(struct platform_device *pdev)
opp_data->cpu_dev = get_cpu_device(0);
if (!opp_data->cpu_dev) {
pr_err("%s: Failed to get device for CPU0\n", __func__);
- ret = ENODEV;
+ ret = -ENODEV;
goto free_opp_data;
}