summaryrefslogtreecommitdiff
path: root/drivers/dma/ti/dma-crossbar.c
diff options
context:
space:
mode:
authorMiaoqian Lin <linmq006@gmail.com>2022-06-05 07:27:23 +0300
committerVinod Koul <vkoul@kernel.org>2022-06-09 09:00:30 +0300
commitc132fe78ad7b4ce8b5d49a501a15c29d08eeb23a (patch)
tree1fc0892f7c16bb859acb26aa8a3be6ebdc8dab88 /drivers/dma/ti/dma-crossbar.c
parentf2906aa863381afb0015a9eb7fefad885d4e5a56 (diff)
downloadlinux-c132fe78ad7b4ce8b5d49a501a15c29d08eeb23a.tar.xz
dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not needed anymore. Add missing of_node_put() in to fix this. Fixes: ec9bfa1e1a79 ("dmaengine: ti-dma-crossbar: dra7: Use bitops instead of idr") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Link: https://lore.kernel.org/r/20220605042723.17668-2-linmq006@gmail.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/ti/dma-crossbar.c')
-rw-r--r--drivers/dma/ti/dma-crossbar.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
index 71d24fc07c00..e34cfb50d241 100644
--- a/drivers/dma/ti/dma-crossbar.c
+++ b/drivers/dma/ti/dma-crossbar.c
@@ -268,6 +268,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
mutex_unlock(&xbar->mutex);
dev_err(&pdev->dev, "Run out of free DMA requests\n");
kfree(map);
+ of_node_put(dma_spec->np);
return ERR_PTR(-ENOMEM);
}
set_bit(map->xbar_out, xbar->dma_inuse);