summaryrefslogtreecommitdiff
path: root/drivers/firmware
diff options
context:
space:
mode:
authorYisheng Xie <xieyisheng1@huawei.com>2016-10-18 17:33:13 +0300
committerIngo Molnar <mingo@kernel.org>2016-10-18 18:11:17 +0300
commit0709a008c9fadc176500ece7395b8b5b8de143e3 (patch)
treece3f2ec2d413da9e432d4f370d550045fb7bf784 /drivers/firmware
parent10714dd37aa7ebb165677b9a793448950ff366ad (diff)
downloadlinux-0709a008c9fadc176500ece7395b8b5b8de143e3.tar.xz
efi/arm*: Fix efi_init() error handling
There's an early memmap() leak in the efi_init() error path, fix it. Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com> Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Will Deacon <will.deacon@arm.com> Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/20161018143318.15673-4-matt@codeblueprint.co.uk Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'drivers/firmware')
-rw-r--r--drivers/firmware/efi/arm-init.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/arm-init.c
index 8efe13075c92..f853ad2c4ca0 100644
--- a/drivers/firmware/efi/arm-init.c
+++ b/drivers/firmware/efi/arm-init.c
@@ -244,8 +244,10 @@ void __init efi_init(void)
"Unexpected EFI_MEMORY_DESCRIPTOR version %ld",
efi.memmap.desc_version);
- if (uefi_init() < 0)
+ if (uefi_init() < 0) {
+ efi_memmap_unmap();
return;
+ }
reserve_regions();
efi_memattr_init();