diff options
author | Qiushi Wu <wu000273@umn.edu> | 2020-05-28 21:38:04 +0300 |
---|---|---|
committer | Sasha Levin <sashal@kernel.org> | 2020-07-01 06:17:10 +0300 |
commit | a717bbd11e3962e8144ef3e34a0533231dd2c409 (patch) | |
tree | fd8288f4294308587c133a683fba545d352dcf10 /drivers/firmware | |
parent | 932a580890e085970f212080503d35c44d4d982f (diff) | |
download | linux-a717bbd11e3962e8144ef3e34a0533231dd2c409.tar.xz |
efi/esrt: Fix reference count leak in esre_create_sysfs_entry.
[ Upstream commit 4ddf4739be6e375116c375f0a68bf3893ffcee21 ]
kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object. Previous
commit "b8eb718348b8" fixed a similar problem.
Fixes: 0bb549052d33 ("efi: Add esrt support")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Link: https://lore.kernel.org/r/20200528183804.4497-1-wu000273@umn.edu
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/firmware')
-rw-r--r-- | drivers/firmware/efi/esrt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c index 5d06bd247d07..2f6204b2fdd3 100644 --- a/drivers/firmware/efi/esrt.c +++ b/drivers/firmware/efi/esrt.c @@ -180,7 +180,7 @@ static int esre_create_sysfs_entry(void *esre, int entry_num) rc = kobject_init_and_add(&entry->kobj, &esre1_ktype, NULL, "entry%d", entry_num); if (rc) { - kfree(entry); + kobject_put(&entry->kobj); return rc; } } |