diff options
| author | Nicolas Saenz Julienne <nsaenzjulienne@suse.de> | 2018-12-21 22:25:18 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-12-05 11:21:01 +0300 |
| commit | d393cc60c6ea2b74b42c799f8ae71ea8f38699cb (patch) | |
| tree | b0050b59fd4d6a87b48e0e57531248f03dd94645 /drivers/firmware | |
| parent | 77a9b90d266b06abf3c90073b14fa83543b86234 (diff) | |
| download | linux-d393cc60c6ea2b74b42c799f8ae71ea8f38699cb.tar.xz | |
firmware: arm_sdei: fix wrong of_node_put() in init function
[ Upstream commit c3790b3799f8d75d93d26f6fd7bb569fc8c8b0cb ]
After finding a "firmware" dt node arm_sdei tries to match it's
compatible string with it. To do so it's calling of_find_matching_node()
which already takes care of decreasing the refcount on the "firmware"
node. We are then incorrectly decreasing the refcount on that node
again.
This patch removes the unwarranted call to of_node_put().
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Signed-off-by: James Morse <james.morse@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/firmware')
| -rw-r--r-- | drivers/firmware/arm_sdei.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c index 1ea71640fdc2..dffb47c6b480 100644 --- a/drivers/firmware/arm_sdei.c +++ b/drivers/firmware/arm_sdei.c @@ -1017,7 +1017,6 @@ static bool __init sdei_present_dt(void) return false; np = of_find_matching_node(fw_np, sdei_of_match); - of_node_put(fw_np); if (!np) return false; |