diff options
| author | Ruan Jinjie <ruanjinjie@huawei.com> | 2023-07-27 15:40:43 +0300 |
|---|---|---|
| committer | Bartosz Golaszewski <bartosz.golaszewski@linaro.org> | 2023-07-29 16:50:44 +0300 |
| commit | 291bc793a0083ce69acc7ceb77c9ec7af4401093 (patch) | |
| tree | af52c62fcef19e69db20ed213972baafad97454a /drivers/gpio | |
| parent | 92f7a35836c2e13ae5f0dc8c7f889e92f66a9d19 (diff) | |
| download | linux-291bc793a0083ce69acc7ceb77c9ec7af4401093.tar.xz | |
gpio: omap: Remove redundant dev_err_probe() and zero value handle code
There is no need to call the dev_err_probe() function directly to print
a custom message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.
And the code to handle bank->irq = 0 is redundant because
platform_get_irq() do not return 0.
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Diffstat (limited to 'drivers/gpio')
| -rw-r--r-- | drivers/gpio/gpio-omap.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index 2b78fde74e30..a927680c66f8 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1412,11 +1412,8 @@ static int omap_gpio_probe(struct platform_device *pdev) bank->dev = dev; bank->irq = platform_get_irq(pdev, 0); - if (bank->irq <= 0) { - if (!bank->irq) - bank->irq = -ENXIO; - return dev_err_probe(dev, bank->irq, "can't get irq resource\n"); - } + if (bank->irq < 0) + return bank->irq; bank->chip.parent = dev; bank->chip.owner = THIS_MODULE; |