summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
diff options
context:
space:
mode:
authorLancelot SIX <lancelot.six@amd.com>2024-04-10 16:14:13 +0300
committerAlex Deucher <alexander.deucher@amd.com>2024-05-01 04:59:16 +0300
commitf5b9053398e70a0c10aa9cb4dd5910ab6bc457c5 (patch)
treee9a1630b68832741d83cc2b155bd87fc0542c719 /drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
parent6f0c228ed9184287031a66b46a79e5a3d2e73a86 (diff)
downloadlinux-f5b9053398e70a0c10aa9cb4dd5910ab6bc457c5.tar.xz
drm/amdkfd: Flush the process wq before creating a kfd_process
There is a race condition when re-creating a kfd_process for a process. This has been observed when a process under the debugger executes exec(3). In this scenario: - The process executes exec. - This will eventually release the process's mm, which will cause the kfd_process object associated with the process to be freed (kfd_process_free_notifier decrements the reference count to the kfd_process to 0). This causes kfd_process_ref_release to enqueue kfd_process_wq_release to the kfd_process_wq. - The debugger receives the PTRACE_EVENT_EXEC notification, and tries to re-enable AMDGPU traps (KFD_IOC_DBG_TRAP_ENABLE). - When handling this request, KFD tries to re-create a kfd_process. This eventually calls kfd_create_process and kobject_init_and_add. At this point the call to kobject_init_and_add can fail because the old kfd_process.kobj has not been freed yet by kfd_process_wq_release. This patch proposes to avoid this race by making sure to drain kfd_process_wq before creating a new kfd_process object. This way, we know that any cleanup task is done executing when we reach kobject_init_and_add. Signed-off-by: Lancelot SIX <lancelot.six@amd.com> Reviewed-by: Felix Kuehling <felix.kuehling@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c')
0 files changed, 0 insertions, 0 deletions