diff options
| author | Matt Roper <matthew.d.roper@intel.com> | 2022-01-28 02:43:34 +0300 |
|---|---|---|
| committer | Matt Roper <matthew.d.roper@intel.com> | 2022-02-02 18:59:54 +0300 |
| commit | ce2fce2513c5c1076f2a2d6e977c0ac523aad5e3 (patch) | |
| tree | 72b7df42bc4c26c0e241b4acbb31a6873a497f04 /drivers/gpu/drm/i915/gt/gen2_engine_cs.c | |
| parent | 0d6419e9c855dea476300e2bb81d29105fe76d38 (diff) | |
| download | linux-ce2fce2513c5c1076f2a2d6e977c0ac523aad5e3.tar.xz | |
drm/i915: Only include i915_reg.h from .c files
Several of our i915 header files, have been including i915_reg.h. This
means that any change to i915_reg.h will trigger a full rebuild of
pretty much every file of the driver, even those that don't have any
kind of register access. Let's delete the i915_reg.h include from all
headers and add an explicit include from the .c files that truly
need the register definitions; those that need a definition of
i915_reg_t for a function definition can get it from i915_reg_defs.h
instead.
We also remove two non-register #define's (VLV_DISPLAY_BASE and
GEN12_SFC_DONE_MAX) into i915_reg_defs.h to allow us to drop the
i915_reg.h include from a couple of headers.
There's probably a lot more header dependency optimization possible, but
the changes here roughly cut the number of files compiled after 'touch
i915_reg.h' in half --- a good first step.
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220127234334.4016964-7-matthew.d.roper@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/gt/gen2_engine_cs.c')
| -rw-r--r-- | drivers/gpu/drm/i915/gt/gen2_engine_cs.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpu/drm/i915/gt/gen2_engine_cs.c b/drivers/gpu/drm/i915/gt/gen2_engine_cs.c index e0e8d228b31f..1c82caf525c3 100644 --- a/drivers/gpu/drm/i915/gt/gen2_engine_cs.c +++ b/drivers/gpu/drm/i915/gt/gen2_engine_cs.c @@ -5,6 +5,7 @@ #include "gen2_engine_cs.h" #include "i915_drv.h" +#include "i915_reg.h" #include "intel_engine.h" #include "intel_engine_regs.h" #include "intel_gpu_commands.h" |