summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/i915/intel_region_lmem.c
diff options
context:
space:
mode:
authorMatthew Auld <matthew.auld@intel.com>2019-11-06 15:31:35 +0300
committerChris Wilson <chris@chris-wilson.co.uk>2019-11-06 17:34:10 +0300
commitcddb85dc1eca10300eb23873f6d9e84267aabd9d (patch)
tree774dd279b8e84980628de14409684ca191e02df3 /drivers/gpu/drm/i915/intel_region_lmem.c
parent1e460bf9eaa59047183689ac28a772147eb747c9 (diff)
downloadlinux-cddb85dc1eca10300eb23873f6d9e84267aabd9d.tar.xz
drm/i915/lmem: fixup fake lmem teardown
We should not be unconditionally calling release_fake_lmem_bar. Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Lucas De Marchi <lucas.demarchi@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Link: https://patchwork.freedesktop.org/patch/msgid/20191106123135.12441-1-matthew.auld@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/intel_region_lmem.c')
-rw-r--r--drivers/gpu/drm/i915/intel_region_lmem.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/intel_region_lmem.c b/drivers/gpu/drm/i915/intel_region_lmem.c
index 583118095635..eddb392917aa 100644
--- a/drivers/gpu/drm/i915/intel_region_lmem.c
+++ b/drivers/gpu/drm/i915/intel_region_lmem.c
@@ -51,8 +51,10 @@ static int init_fake_lmem_bar(struct intel_memory_region *mem)
static void release_fake_lmem_bar(struct intel_memory_region *mem)
{
- if (drm_mm_node_allocated(&mem->fake_mappable))
- drm_mm_remove_node(&mem->fake_mappable);
+ if (!drm_mm_node_allocated(&mem->fake_mappable))
+ return;
+
+ drm_mm_remove_node(&mem->fake_mappable);
dma_unmap_resource(&mem->i915->drm.pdev->dev,
mem->remap_addr,