summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/mediatek
diff options
context:
space:
mode:
authorRob Clark <robdclark@chromium.org>2023-01-20 02:12:55 +0300
committerChun-Kuang Hu <chunkuang.hu@kernel.org>2023-01-27 06:14:23 +0300
commit4deef811828e87e26a978d5d6433b261d4713849 (patch)
treeb425c0e7a03471c282b6866573587e393a8014d3 /drivers/gpu/drm/mediatek
parent2ea8aec56bf17d5032364c227bde1c871a7cc6fd (diff)
downloadlinux-4deef811828e87e26a978d5d6433b261d4713849.tar.xz
drm/mediatek: Drop unbalanced obj unref
In the error path, mtk_drm_gem_object_mmap() is dropping an obj reference that it doesn't own. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Rob Clark <robdclark@chromium.org> Link: https://patchwork.kernel.org/project/linux-mediatek/patch/20230119231255.2883365-1-robdclark@gmail.com/ Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Diffstat (limited to 'drivers/gpu/drm/mediatek')
-rw-r--r--drivers/gpu/drm/mediatek/mtk_drm_gem.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index 3057790d9264..ec0518aa9315 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -169,8 +169,6 @@ static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj,
ret = dma_mmap_attrs(priv->dma_dev, vma, mtk_gem->cookie,
mtk_gem->dma_addr, obj->size, mtk_gem->dma_attrs);
- if (ret)
- drm_gem_vm_close(vma);
return ret;
}