diff options
| author | Rob Clark <robdclark@chromium.org> | 2020-10-23 19:51:18 +0300 |
|---|---|---|
| committer | Rob Clark <robdclark@chromium.org> | 2020-11-05 03:00:56 +0300 |
| commit | fb1a1fcbacefd839503e94a66a467809ade27b2c (patch) | |
| tree | 24b94b5098725320f98fc36bb76b997cd6e6dfc3 /drivers/gpu/drm/msm/msm_gem.c | |
| parent | 964d2f97e74b3951973bc22d8a5547f6c0d505b4 (diff) | |
| download | linux-fb1a1fcbacefd839503e94a66a467809ade27b2c.tar.xz | |
drm/msm: Remove obj->gpu
It cannot be atomically updated with obj->active_count, and the only
purpose is a useless WARN_ON() (which becomes a buggy WARN_ON() once
retire_submits() is not serialized with incoming submits via
struct_mutex)
Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
Signed-off-by: Rob Clark <robdclark@chromium.org>
Diffstat (limited to 'drivers/gpu/drm/msm/msm_gem.c')
| -rw-r--r-- | drivers/gpu/drm/msm/msm_gem.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index 084131db89d2..dd3c21bb8740 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -774,7 +774,6 @@ void msm_gem_active_get(struct drm_gem_object *obj, struct msm_gpu *gpu) if (!atomic_fetch_inc(&msm_obj->active_count)) { mutex_lock(&priv->mm_lock); - msm_obj->gpu = gpu; list_del_init(&msm_obj->mm_list); list_add_tail(&msm_obj->mm_list, &gpu->active_list); mutex_unlock(&priv->mm_lock); @@ -790,7 +789,6 @@ void msm_gem_active_put(struct drm_gem_object *obj) if (!atomic_dec_return(&msm_obj->active_count)) { mutex_lock(&priv->mm_lock); - msm_obj->gpu = NULL; list_del_init(&msm_obj->mm_list); list_add_tail(&msm_obj->mm_list, &priv->inactive_list); mutex_unlock(&priv->mm_lock); |