diff options
| author | Rob Clark <robdclark@chromium.org> | 2023-11-21 03:38:48 +0300 |
|---|---|---|
| committer | Rob Clark <robdclark@chromium.org> | 2023-12-10 21:23:13 +0300 |
| commit | 2d7d2c4e84802485a1e765bd0732d41526dcf25c (patch) | |
| tree | 57b92f0c67adf2b7b86ec32558d859cc2081b636 /drivers/gpu/drm/msm/msm_ringbuffer.c | |
| parent | ceab575cafed594fb3cee1bec01a0e4ed5e2d752 (diff) | |
| download | linux-2d7d2c4e84802485a1e765bd0732d41526dcf25c.tar.xz | |
drm/msm/gem: Split out submit_unpin_objects() helper
Untangle unpinning from unlock/unref loop. The unpin only happens in
error paths so it is easier to decouple from the normal unlock path.
Since we never have an intermediate state where a subset of buffers
are pinned (ie. we never bail out of the pin or unpin loops) we can
replace the bo state flag bit with a global flag in the submit.
Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/568335/
Diffstat (limited to 'drivers/gpu/drm/msm/msm_ringbuffer.c')
| -rw-r--r-- | drivers/gpu/drm/msm/msm_ringbuffer.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/msm/msm_ringbuffer.c b/drivers/gpu/drm/msm/msm_ringbuffer.c index 4968568e3b54..4bc13f7d005a 100644 --- a/drivers/gpu/drm/msm/msm_ringbuffer.c +++ b/drivers/gpu/drm/msm/msm_ringbuffer.c @@ -29,9 +29,10 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job) struct drm_gem_object *obj = submit->bos[i].obj; msm_gem_unpin_active(obj); - submit->bos[i].flags &= ~BO_PINNED; } + submit->bos_pinned = false; + mutex_unlock(&priv->lru.lock); msm_gpu_submit(gpu, submit); |