diff options
| author | Dmitry Baryshkov <dmitry.baryshkov@linaro.org> | 2022-05-02 11:24:20 +0300 |
|---|---|---|
| committer | Dmitry Baryshkov <dmitry.baryshkov@linaro.org> | 2022-05-07 02:10:34 +0300 |
| commit | 4c1e9df7264567617ba2ed620338dfcef0618c39 (patch) | |
| tree | 8b223a2c63b94129eb9b781cf3541d00cce3c553 /drivers/gpu/drm/msm | |
| parent | 88334f8c937a4c9083a73fd1e8b129d00100c472 (diff) | |
| download | linux-4c1e9df7264567617ba2ed620338dfcef0618c39.tar.xz | |
drm/msm/dpu: don't access mode pointer before it is set
Move the initializer for the mode variable to the declaration point to
remove unitialized variable access from the DEBUG_DPU macro. This fixes
the following warning:
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:250:37: note: initialize the variable 'mode' to silence this warning
Fixes: d7d0e73f7de3 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for writeback")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/484346/
Link: https://lore.kernel.org/r/20220502082420.48409-1-dmitry.baryshkov@linaro.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Diffstat (limited to 'drivers/gpu/drm/msm')
| -rw-r--r-- | drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c index f4a79715a02e..4829d1ce0cf8 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c @@ -247,7 +247,7 @@ static int dpu_encoder_phys_wb_atomic_check( struct drm_connector_state *conn_state) { struct drm_framebuffer *fb; - const struct drm_display_mode *mode; + const struct drm_display_mode *mode = &crtc_state->mode; DPU_DEBUG("[atomic_check:%d, \"%s\",%d,%d]\n", phys_enc->wb_idx, mode->name, mode->hdisplay, mode->vdisplay); @@ -256,7 +256,6 @@ static int dpu_encoder_phys_wb_atomic_check( return 0; fb = conn_state->writeback_job->fb; - mode = &crtc_state->mode; if (!conn_state || !conn_state->connector) { DPU_ERROR("invalid connector state\n"); |