diff options
| author | Javier Martinez Canillas <javierm@redhat.com> | 2023-10-14 10:15:03 +0300 |
|---|---|---|
| committer | Javier Martinez Canillas <javierm@redhat.com> | 2023-10-18 10:53:25 +0300 |
| commit | ec5dceb8180f0cb110dc7029d55d6a83d0583015 (patch) | |
| tree | d6c5c1979829f39815ab404afab92aeccd64f17f /drivers/gpu/drm/solomon/ssd130x.h | |
| parent | f7749a549b4f4db0c02e6b3d3800ea400dd76c12 (diff) | |
| download | linux-ec5dceb8180f0cb110dc7029d55d6a83d0583015.tar.xz | |
drm/ssd130x: Replace .page_height field in device info with a constant
This deemed useful to avoid hardcoding a page height and allow to support
other Solomon controller families, but dividing the screen in pages seems
to be something that is specific to the SSD130x chip family.
For example, SSD132x chip family divides the screen in segments (columns)
and common outputs (rows), so the concept of screen pages does not exist
for the SSD132x family.
Let's drop this field from the device info struct and just use a constant
SSD130X_PAGE_HEIGHT macro to define the page height. While being there,
replace hardcoded 8 values in places where it is used as the page height.
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20231014071520.1342189-2-javierm@redhat.com
Diffstat (limited to 'drivers/gpu/drm/solomon/ssd130x.h')
| -rw-r--r-- | drivers/gpu/drm/solomon/ssd130x.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/gpu/drm/solomon/ssd130x.h b/drivers/gpu/drm/solomon/ssd130x.h index aa39b13615eb..bbe374453605 100644 --- a/drivers/gpu/drm/solomon/ssd130x.h +++ b/drivers/gpu/drm/solomon/ssd130x.h @@ -39,7 +39,6 @@ struct ssd130x_deviceinfo { u32 default_dclk_frq; u32 default_width; u32 default_height; - u32 page_height; bool need_pwm; bool need_chargepump; bool page_mode_only; |