diff options
| author | Maxime Ripard <maxime@cerno.tech> | 2022-02-25 17:35:33 +0300 |
|---|---|---|
| committer | Maxime Ripard <maxime@cerno.tech> | 2022-04-06 13:41:54 +0300 |
| commit | 5b6ef06ea6225570bc0b33325306c7b8c6bdf5eb (patch) | |
| tree | fde142636d01e6c641493058f92ff7fd20af2d6d /drivers/gpu/drm/vc4 | |
| parent | 66230cc9b68a0b20d5ab5573e80adbafe2c6284f (diff) | |
| download | linux-5b6ef06ea6225570bc0b33325306c7b8c6bdf5eb.tar.xz | |
drm/vc4: Add logging and comments
The HVS core clock isn't really obvious, so let's add a bunch more
comments and some logging for easier debugging.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20220225143534.405820-12-maxime@cerno.tech
Diffstat (limited to 'drivers/gpu/drm/vc4')
| -rw-r--r-- | drivers/gpu/drm/vc4/vc4_kms.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c index bffd81d4bfcf..4d01697a77b1 100644 --- a/drivers/gpu/drm/vc4/vc4_kms.c +++ b/drivers/gpu/drm/vc4/vc4_kms.c @@ -390,8 +390,15 @@ static void vc4_atomic_commit_tail(struct drm_atomic_state *state) 500000000, new_hvs_state->core_clock_rate); + drm_dbg(dev, "Raising the core clock at %lu Hz\n", core_rate); + + /* + * Do a temporary request on the core clock during the + * modeset. + */ clk_set_min_rate(hvs->core_clk, core_rate); } + drm_atomic_helper_commit_modeset_disables(dev, state); vc4_ctm_commit(vc4, state); @@ -417,6 +424,10 @@ static void vc4_atomic_commit_tail(struct drm_atomic_state *state) drm_dbg(dev, "Running the core clock at %lu Hz\n", new_hvs_state->core_clock_rate); + /* + * Request a clock rate based on the current HVS + * requirements. + */ clk_set_min_rate(hvs->core_clk, new_hvs_state->core_clock_rate); } } |