summaryrefslogtreecommitdiff
path: root/drivers/gpu
diff options
context:
space:
mode:
authorDeepak R Varma <drv@mailo.com>2023-03-01 22:48:06 +0300
committerThierry Reding <treding@nvidia.com>2023-04-04 19:04:57 +0300
commit3105e42c75e0f80a6933e29291a94f669b869dbd (patch)
tree960c8abc144675e41e7e9cdf429a2a13182badfd /drivers/gpu
parent13fcbcb97d05be14c5ada46b5b6cf71f8c96ad50 (diff)
downloadlinux-3105e42c75e0f80a6933e29291a94f669b869dbd.tar.xz
drm/tegra: sor: Remove redundant error logging
A call to platform_get_irq() already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well. Issue identified using platform_get_irq.cocci coccicheck script. Signed-off-by: Deepak R Varma <drv@mailo.com> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> Signed-off-by: Thierry Reding <treding@nvidia.com>
Diffstat (limited to 'drivers/gpu')
-rw-r--r--drivers/gpu/drm/tegra/sor.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index e617d55f6f3c..8eafbdd3620c 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -3799,10 +3799,8 @@ static int tegra_sor_probe(struct platform_device *pdev)
}
err = platform_get_irq(pdev, 0);
- if (err < 0) {
- dev_err(&pdev->dev, "failed to get IRQ: %d\n", err);
+ if (err < 0)
goto remove;
- }
sor->irq = err;