diff options
| author | Vladis Dronov <vdronov@redhat.com> | 2019-01-29 13:58:35 +0300 |
|---|---|---|
| committer | Benjamin Tissoires <benjamin.tissoires@redhat.com> | 2019-01-29 14:09:11 +0300 |
| commit | 13054abbaa4f1fd4e6f3b4b63439ec033b4c8035 (patch) | |
| tree | e1385b1d1ad52472b30ec37fb46358d4069f16a6 /drivers/hid/hid-steam.c | |
| parent | 1950f462916edc9581168ca8d5882a8101e8bbcf (diff) | |
| download | linux-13054abbaa4f1fd4e6f3b4b63439ec033b4c8035.tar.xz | |
HID: debug: fix the ring buffer implementation
Ring buffer implementation in hid_debug_event() and hid_debug_events_read()
is strange allowing lost or corrupted data. After commit 717adfdaf147
("HID: debug: check length before copy_to_user()") it is possible to enter
an infinite loop in hid_debug_events_read() by providing 0 as count, this
locks up a system. Fix this by rewriting the ring buffer implementation
with kfifo and simplify the code.
This fixes CVE-2019-3819.
v2: fix an execution logic and add a comment
v3: use __set_current_state() instead of set_current_state()
Link: https://bugzilla.redhat.com/show_bug.cgi?id=1669187
Cc: stable@vger.kernel.org # v4.18+
Fixes: cd667ce24796 ("HID: use debugfs for events/reports dumping")
Fixes: 717adfdaf147 ("HID: debug: check length before copy_to_user()")
Signed-off-by: Vladis Dronov <vdronov@redhat.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Diffstat (limited to 'drivers/hid/hid-steam.c')
0 files changed, 0 insertions, 0 deletions