summaryrefslogtreecommitdiff
path: root/drivers/hid
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2022-10-28 16:40:43 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-11-16 11:57:08 +0300
commit8597b59e3d22b27849bd3e4f92a3d466774bfb04 (patch)
treebbc6da719cb917ac2264eb8540e2465c46ea9a09 /drivers/hid
parent8c80b2fca4112d724dde477aed13f7b0510a2792 (diff)
downloadlinux-8597b59e3d22b27849bd3e4f92a3d466774bfb04.tar.xz
HID: hyperv: fix possible memory leak in mousevsc_probe()
[ Upstream commit b5bcb94b0954a026bbd671741fdb00e7141f9c91 ] If hid_add_device() returns error, it should call hid_destroy_device() to free hid_dev which is allocated in hid_allocate_device(). Fixes: 74c4fb058083 ("HID: hv_mouse: Properly add the hid device") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Wei Liu <wei.liu@kernel.org> Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/hid')
-rw-r--r--drivers/hid/hid-hyperv.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
index 978ee2aab2d4..b7704dd6809d 100644
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -498,7 +498,7 @@ static int mousevsc_probe(struct hv_device *device,
ret = hid_add_device(hid_dev);
if (ret)
- goto probe_err1;
+ goto probe_err2;
ret = hid_parse(hid_dev);