summaryrefslogtreecommitdiff
path: root/drivers/hid
diff options
context:
space:
mode:
authorDongliang Mu <mudongliangabcd@gmail.com>2022-01-22 12:48:26 +0300
committerJiri Kosina <jkosina@suse.cz>2022-01-24 11:03:21 +0300
commit817b8b9c5396d2b2d92311b46719aad5d3339dbe (patch)
tree7ef55414bc457869230f3304dd049eacb0133ad1 /drivers/hid
parente26a78057c25dd56f112d536319c38735ed92ba4 (diff)
downloadlinux-817b8b9c5396d2b2d92311b46719aad5d3339dbe.tar.xz
HID: elo: fix memory leak in elo_probe
When hid_parse() in elo_probe() fails, it forgets to call usb_put_dev to decrease the refcount. Fix this by adding usb_put_dev() in the error handling code of elo_probe(). Fixes: fbf42729d0e9 ("HID: elo: update the reference count of the usb device structure") Reported-by: syzkaller <syzkaller@googlegroups.com> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
-rw-r--r--drivers/hid/hid-elo.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/hid-elo.c b/drivers/hid/hid-elo.c
index 8e960d7b233b..9b42b0cdeef0 100644
--- a/drivers/hid/hid-elo.c
+++ b/drivers/hid/hid-elo.c
@@ -262,6 +262,7 @@ static int elo_probe(struct hid_device *hdev, const struct hid_device_id *id)
return 0;
err_free:
+ usb_put_dev(udev);
kfree(priv);
return ret;
}