summaryrefslogtreecommitdiff
path: root/drivers/hsi
diff options
context:
space:
mode:
authorYuan Can <yuancan@huawei.com>2022-11-24 14:33:32 +0300
committerSebastian Reichel <sebastian.reichel@collabora.com>2022-11-25 03:04:21 +0300
commit3ffa9f713c39a213a08d9ff13ab983a8aa5d8b5d (patch)
tree347ff9e1260c577e3ae1929245a605a5d2d0c9cf /drivers/hsi
parent8acbca3a92b859e3dfe0538254acd5bd5b4632b1 (diff)
downloadlinux-3ffa9f713c39a213a08d9ff13ab983a8aa5d8b5d.tar.xz
HSI: omap_ssi_core: Fix error handling in ssi_init()
The ssi_init() returns the platform_driver_register() directly without checking its return value, if platform_driver_register() failed, the ssi_pdriver is not unregistered. Fix by unregister ssi_pdriver when the last platform_driver_register() failed. Fixes: 0fae198988b8 ("HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module") Signed-off-by: Yuan Can <yuancan@huawei.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'drivers/hsi')
-rw-r--r--drivers/hsi/controllers/omap_ssi_core.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
index 052cf3e92dd6..26f2c3c01297 100644
--- a/drivers/hsi/controllers/omap_ssi_core.c
+++ b/drivers/hsi/controllers/omap_ssi_core.c
@@ -631,7 +631,13 @@ static int __init ssi_init(void) {
if (ret)
return ret;
- return platform_driver_register(&ssi_port_pdriver);
+ ret = platform_driver_register(&ssi_port_pdriver);
+ if (ret) {
+ platform_driver_unregister(&ssi_pdriver);
+ return ret;
+ }
+
+ return 0;
}
module_init(ssi_init);