summaryrefslogtreecommitdiff
path: root/drivers/hsi
diff options
context:
space:
mode:
authorMiaoqian Lin <linmq006@gmail.com>2022-04-04 11:52:32 +0300
committerSebastian Reichel <sre@kernel.org>2022-08-29 19:08:48 +0300
commit9a2ea132df860177b33c9fd421b26c4e9a0a9396 (patch)
tree8bc498356ff3339458d1216c1792aa22b1536b42 /drivers/hsi
parent77e0ccd6248272fd60ce9cce101b6e27e8d50d47 (diff)
downloadlinux-9a2ea132df860177b33c9fd421b26c4e9a0a9396.tar.xz
HSI: omap_ssi: Fix refcount leak in ssi_probe
When returning or breaking early from a for_each_available_child_of_node() loop, we need to explicitly call of_node_put() on the child node to possibly release the node. Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'drivers/hsi')
-rw-r--r--drivers/hsi/controllers/omap_ssi_core.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
index 44a3f5660c10..eb9820158318 100644
--- a/drivers/hsi/controllers/omap_ssi_core.c
+++ b/drivers/hsi/controllers/omap_ssi_core.c
@@ -524,6 +524,7 @@ static int ssi_probe(struct platform_device *pd)
if (!childpdev) {
err = -ENODEV;
dev_err(&pd->dev, "failed to create ssi controller port\n");
+ of_node_put(child);
goto out3;
}
}