summaryrefslogtreecommitdiff
path: root/drivers/hwmon/atxp1.c
diff options
context:
space:
mode:
authorChu Lin <linchuyuan@google.com>2020-06-24 01:13:08 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-07-09 10:37:10 +0300
commitcbec0023eb85a55f24554b7f2df53ca37deff1b9 (patch)
treedcc62f6f5044978f4ca68418e4772a17c9517460 /drivers/hwmon/atxp1.c
parent844900c736779ed38b19d509e84ea4761861b777 (diff)
downloadlinux-cbec0023eb85a55f24554b7f2df53ca37deff1b9.tar.xz
hwmon: (max6697) Make sure the OVERT mask is set correctly
[ Upstream commit 016983d138cbe99a5c0aaae0103ee88f5300beb3 ] Per the datasheet for max6697, OVERT mask and ALERT mask are different. For example, the 7th bit of OVERT is the local channel but for alert mask, the 6th bit is the local channel. Therefore, we can't apply the same mask for both registers. In addition to that, the max6697 driver is supposed to be compatibale with different models. I manually went over all the listed chips and made sure all chip types have the same layout. Testing; mask value of 0x9 should map to 0x44 for ALERT and 0x84 for OVERT. I used iotool to read the reg value back to verify. I only tested this change on max6581. Reference: https://datasheets.maximintegrated.com/en/ds/MAX6581.pdf https://datasheets.maximintegrated.com/en/ds/MAX6697.pdf https://datasheets.maximintegrated.com/en/ds/MAX6699.pdf Signed-off-by: Chu Lin <linchuyuan@google.com> Fixes: 5372d2d71c46e ("hwmon: Driver for Maxim MAX6697 and compatibles") Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/hwmon/atxp1.c')
0 files changed, 0 insertions, 0 deletions