diff options
| author | Justin Stitt <justinstitt@google.com> | 2023-09-19 08:22:51 +0300 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2023-09-30 00:48:31 +0300 |
| commit | 66f8a4a0cc69ea1ddbebb6afcd8bd47511e9929c (patch) | |
| tree | 37a5c5aff16fddc08dd0b0e5d89f2f4938c4418b /drivers/hwmon/ibmpowernv.c | |
| parent | abe6db6c43fa59c4755f210e92d6fbe97a0ad1aa (diff) | |
| download | linux-66f8a4a0cc69ea1ddbebb6afcd8bd47511e9929c.tar.xz | |
hwmon: (ibmpowernv) Replace deprecated strncpy() with memcpy()
`strncpy` is deprecated for use on NUL-terminated destination strings [1].
A suitable replacement is `memcpy` as we've already precisely calculated
the number of bytes to copy while `buf` has been explicitly
zero-initialized:
| char buf[8] = { 0 };
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Tested-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20230919-strncpy-drivers-hwmon-ibmpowernv-c-v2-1-37d3e64172bc@google.com
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'drivers/hwmon/ibmpowernv.c')
| -rw-r--r-- | drivers/hwmon/ibmpowernv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c index 594254d6a72d..70ca833259ab 100644 --- a/drivers/hwmon/ibmpowernv.c +++ b/drivers/hwmon/ibmpowernv.c @@ -234,7 +234,7 @@ static int get_sensor_index_attr(const char *name, u32 *index, char *attr) if (copy_len >= sizeof(buf)) return -EINVAL; - strncpy(buf, hash_pos + 1, copy_len); + memcpy(buf, hash_pos + 1, copy_len); err = kstrtou32(buf, 10, index); if (err) |